Skip to content

increase disk iops, throughput and size #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2025
Merged

increase disk iops, throughput and size #408

merged 1 commit into from
Jan 27, 2025

Conversation

@DaMandal0rian
Copy link
Contributor

@DaMandal0rian DaMandal0rian commented Jan 27, 2025 •
edited
Loading

PR Type

Enhancement

Description

  • Increased default disk volume size from 200G to 1500G.

  • Enhanced IOPS and throughput for multiple AWS instances.

  • Updated Terraform configurations for improved disk performance.

Changes walkthrough 📝

Relevant files
Enhancement
variables.tf
Updated default disk volume size                                                 

explorer/terraform/aws/mainnet/variables.tf

  • Increased default disk_volume_size from 200 to 1500.
 +1/-1     
instances.tf
Enhanced disk performance for AWS instances                           

templates/terraform/subql/base/instances.tf

  • Increased iops from 3000 to 12000 for multiple instances.
  • Increased throughput from 250 to 750 for multiple instances.
  • Enhanced disk performance configurations for AWS instances.
    		• +8/-8     
    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
    •

    @github-actions
    Copy link

    github-actions bot commented Jan 27, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Change

    The default disk volume size has been increased from 200 to 1500. Ensure this change aligns with the expected resource requirements and does not lead to unnecessary cost increases.

    variable "disk_volume_size" {
  type    = number
  default = 1500
    Performance Adjustment

    The IOPS and throughput values for multiple AWS instances have been significantly increased. Verify that these changes are necessary and that they align with the expected workload requirements.

    ebs_optimized = true
ebs_block_device {
  device_name = "/dev/sda1"
  volume_size = var.blue-subql-node-config.disk-volume-size
  volume_type = var.blue-subql-node-config.disk-volume-type
  iops        = 12000
  throughput  = 750

    @github-actions
    Copy link

    github-actions bot commented Jan 27, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Validate IOPS and throughput compatibility

    Ensure that the increased iops (12000) and throughput (750) values are supported by
    the selected volume_type and do not exceed AWS limits for the specified instance
    type.

    templates/terraform/subql/base/instances.tf [18-19]

    -iops        = 12000
-throughput  = 750
+iops        = 12000 # Confirm compatibility with volume_type and instance type
+throughput  = 750 # Ensure within AWS limits
    Suggestion importance[1-10]: 9

    Why: This suggestion highlights the need to confirm compatibility of the increased IOPS and throughput values with the selected volume type and instance type, which is crucial to avoid potential runtime issues or exceeding AWS limits. It is highly relevant and impactful, though it also primarily prompts verification rather than providing a concrete solution.

    		9
    General
    Validate increased disk size default

    Verify that the increased default value for disk_volume_size (1500) aligns with the
    actual storage requirements and cost considerations, as this change significantly
    increases the disk size from 200.

    explorer/terraform/aws/mainnet/variables.tf [91]

    -default = 1500
+default = 1500 # Ensure this value matches storage needs and cost constraints
    Suggestion importance[1-10]: 8

    Why: The suggestion addresses a critical aspect of the change, ensuring that the increased default disk size aligns with storage requirements and cost considerations. This is important as it impacts resource allocation and expenses, but the suggestion is not actionable and only prompts verification, reducing its score slightly.

    		8

    @DaMandal0rian DaMandal0rian merged commit 8bfce5b into main Jan 27, 2025
    1 check passed
    @DaMandal0rian DaMandal0rian deleted the astral-disk-changes branch January 27, 2025 10:46
    @DaMandal0rian DaMandal0rian mentioned this pull request Jan 27, 2025
    Closed
    2 tasks
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    1 more reviewer

    @marc-aurele-besner marc-aurele-besner marc-aurele-besner approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    No one assigned

    Labels

    Review effort [1-5]: 2

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    3 participants

    @DaMandal0rian @marc-aurele-besner